Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NetStandard and nuget #46

Open
saad749 opened this issue Sep 22, 2017 · 14 comments · May be fixed by #133
Open

.NetStandard and nuget #46

saad749 opened this issue Sep 22, 2017 · 14 comments · May be fixed by #133
Labels
feature Suggest a new idea for this project

Comments

@saad749
Copy link

saad749 commented Sep 22, 2017

Hi,

Are there any plans to migrate this project to .net standard and/or have a nuget package?

@aalhour
Copy link
Owner

aalhour commented Oct 16, 2017

Hi @saad749 ,

There are plans but we're not working on them yet. Do you want to submit a PR for it? I'll be more than happy to review and accept it.

Cheers,
Ahmad

@aalhour aalhour added feature Suggest a new idea for this project and removed optimization labels Oct 30, 2019
@nickntg nickntg mentioned this issue Nov 1, 2019
@RyanGrange
Copy link
Contributor

I've got a few changes that move these from netcore2.0 to netstandard2.0 and also updates the nuspec file (adding the dependency for targetFramework .NETStandard2.0). Would it be better to split those up or keep them together since it's the shift from core app to standard library that created the dependency?

@RyanGrange
Copy link
Contributor

I went ahead and created #133 for review. I hope I'm not being rude by going ahead with this rather than waiting for a reply to my earlier question. The PR makes the move from netcoreapp2.0 to netstandard2.0 and I updated the nuspec with the netstandard dependency. Once this gets into nuget.org C-Sharp-Algorithms would be usable by both netcoreapp2 and up, but also older DotNet Framework applications using 4.6.1 and above according to https://docs.microsoft.com/en-us/dotnet/standard/net-standard

@aalhour aalhour linked a pull request May 27, 2020 that will close this issue
8 tasks
@GF-Huang
Copy link

GF-Huang commented Jul 9, 2020

Progress?

@RyanGrange
Copy link
Contributor

I saw the issue was assigned to me, and the PR has been reviewed. What else needs to be done to move this forward?

@nloum
Copy link

nloum commented Nov 3, 2020

This is an awesome library, thanks so much to everyone who has put time and effort into it! This issue is a big deal to me; @PatrykOlejniczak @aalhour would it be possible to move this forward?

@nloum
Copy link

nloum commented Nov 11, 2020

@aalhour I am willing to take over maintaining this project. Is that something you would consider?

@PatrykOlejniczak
Copy link
Collaborator

I really like this idea, i can leave my spot since due to some personal things i didn't have time to take care of this repo, and it's sad that repo losing his potential, but let @aalhour make up his mind

@NdubuisiJr
Copy link
Contributor

How is this coming through?

@saad749 saad749 removed their assignment Apr 2, 2021
@nloum
Copy link

nloum commented May 14, 2021

@aalhour @PatrykOlejniczak @NdubuisiJr I forked the project and released two NuGet packages. I'm open to discussion about this. You guys have laid a great foundation. However due to the busyness of everyone's schedules, I plan to maintain this fork indefinitely. Contributors are welcome.

@NdubuisiJr
Copy link
Contributor

Hi @nloum
Thanks for taking the initiative to do this. I love that you created an organization with the project title. It rocks!

Add me to the organization and the new project, so that I can help maintain it when I get the chance to.

Thanks Again.

@PatrykOlejniczak
Copy link
Collaborator

PatrykOlejniczak commented May 15, 2021

Hi,

Cool, good job, really nice work that will keep project alive :)

Thanks!

@RodneyRichardson
Copy link

Can this project be archived if it's officially moving to https://github.com/C-Sharp-Algorithms/C-Sharp-Algorithms?

@hoowee
Copy link

hoowee commented Jan 6, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Suggest a new idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants