Fixing broken tests #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd recommend to keep this on hold until #38 is finished |
|
Alright. Is there a way for me to label this pull request on hold? |
/cc @aalhour |
|
Hello @hbsock, The migration of the tests package to use a unit testing framework is done, can you please resolve the merge conflicts that you have in this PR? Cheers, |
|
Sure. |
hbsock
force-pushed
the
testing-mainprogram
branch
from
9a0c1c3
to
2aa58ed
Compare
|
It seems the unit tests for SortedDictionaryTests already had the changes I originally had, so I only updated the DLinkedListTest. |
|
Hello @hbsock, Can you please try to rebase your branch once more against master? I have fixed the issue causing the Travis builds to fail. Cheers, |
|
Sure. |
hbsock
force-pushed
the
testing-mainprogram
branch
from
2aa58ed
to
a495ee2
Compare
|
@aalhour could this PR be merged now? Thank you. |
|
Absolutely. Thanks for contributing. |
MetSystem
pushed a commit
to MetSystem/C-Sharp-Algorithms
that referenced
this pull request
Sep 6, 2018
* Fixed doubly linked list test with null enumerator. * Fix DLinkedListTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing broken tests on SortedDictionaryTests and DLinkedListTest