CMAKE: merge LAPACK_LIBRARIES and BLAS_LIBRARIES #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch merge LAPACK_LIBRARIES and BLAS_LIBRARIES lists
with removing of duplicates and replacing ";" with " "
within list to provide proper linking via scifor.pc pkgconfig.
Tested against lapack and openblas system libraries (cmake configuration output of
SF compilation lines:
).Using lapack
initial:
-L${libdir} -lscifor /usr/lib64/liblapack.so;/usr/lib64/libblas.so /usr/lib64/libblas.so
patched:
-L${libdir} -lscifor /usr/lib64/liblapack.so /usr/lib64/libblas.so
Using openblas
initial:
-L${libdir} -lscifor /usr/lib64/libopenblas.so;/usr/lib64/libopenblas.so /usr/lib64/libopenblas.so
patched:
-L${libdir} -lscifor /usr/lib64/libopenblas.so
Related issue: https://github.com/QcmPlab/SciFortran/issues/4#issuecomment-736931796
TESTING:
The patched system installed SciFortran was tested for lapack/openblas with quick example:
Result was compared with python implementation (in fortran case matrix is transpose but it's no matter for triang matrix):