Skip to content

Commit

Permalink
test: increase xds stream timeout to avoid test flakes
Browse files Browse the repository at this point in the history
Stream timeout is a duration we use in tests to make sure the stream does
not stall for too long. In production we do not have such a timeout at
all, and in fact the requests are long-lived and responses are only sent
when there is something (new) to send.

Test stream timeout was 2 seconds, and it would occasionally cause a test
flake, especially if debug logging is enabled. This seems to happen due
to goroutine scheduling, and for this reason debug logging should not be
on for these tests.

Bump the test stream timeout to 4 seconds to further reduce the chance of
a test flake due to it.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
  • Loading branch information
jrajahalme authored and sayboras committed Apr 17, 2024
1 parent 4efe9dd commit 75d144c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/envoy/xds/server_e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ var _ = Suite(&ServerSuite{})

const (
TestTimeout = 10 * time.Second
StreamTimeout = 2 * time.Second
StreamTimeout = 4 * time.Second
)

var (
Expand Down

0 comments on commit 75d144c

Please sign in to comment.