Fix equal items add into set

aantonovdevelop · Sep 19, 2016 · 2be7307 · 2be7307
1 parent b9b6939
commit 2be7307
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/redis.js b/src/redis.js
@@ -71,7 +71,7 @@ function Redis() {
         var self = this;
 
         function save_value(arr, value) {
-            arr.push(value);
+            if (arr.indexOf(value) < 0) arr.push(value);
         }
 
         if (this.store[key]) {

diff --git a/test/redis-mock-test.js b/test/redis-mock-test.js
@@ -135,6 +135,23 @@ describe('Redis', function () {
                 done();
             });
         });
+
+        it('Should replace old value if equal value is exist', function (done) {
+            var test_key = 'test_key';
+            var test_value = 1;
+
+            redis.sadd(test_key, test_value, function (error) {
+                if (error) return done(error);
+
+                redis.sadd(test_key, test_value, function (error) {
+                    if (error) return done(error);
+
+                    assert.equal(redis.store[test_key].length, 1);
+
+                    done();
+                });
+            });
+        });
     });
 
     describe('#smembers', function () {