Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line directives #168

Closed
rleonid opened this issue Feb 7, 2018 · 2 comments
Closed

Line directives #168

rleonid opened this issue Feb 7, 2018 · 2 comments

Comments

@rleonid
Copy link
Collaborator

rleonid commented Feb 7, 2018

I've been rethinking this, in terms of a way of incorporating into jbuilder. I've tried out one scheme where I use jbuilder's copy# to isolate the piece of code that I want to test. Unfortunately, bisect_ppx ignores the directive, so the attribution is "wrong."

I think that this is part of a larger problem of what is the best way of incorporating tests into OCaml projects. I'm on the fence with respect to how expect tests are incorporated into the source code as I like to isolate them into a separate source file, but I'm struggling with having a good end to end solution.

@aantron
Copy link
Owner

aantron commented Feb 7, 2018

I'm not sure what to do about line numbers, but concerning expect tests, I prefer to write them in a different file. This is mainly because a really thorough test suite ends up quite large, and I usually don't want it polluting the source.

@aantron
Copy link
Owner

aantron commented Jul 12, 2019

I'm closing this, since we aren't working on it. Please reopen if closing is wrong :)

@aantron aantron closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants