One mode #50
One mode #50
Conversation
Cleans up issues described in #41. Briefly, all the modes were thread-safe due to the nature of the OCaml runtime, so all have been replaced by the fastest mode. As a consequence: - The BisectThread module has been eliminated. - The runtime has been greatly simplified to a register function (init_with_array) and a dump function called by at_exit. - The old -mode argument now does nothing, but is kept for compatibility. A test was added to ensure it can be used. - The bisect_ppx.fast package is now a duplicate of plain bisect_ppx. - The big comment in runtime.mli has been updated to reflect the many changes since it was written. - Several tests are no longer relevant and have been eliminated. The reference outputs in ppx-integration have not been updated. They will be updated once we are able to run those tests. Resolves #41.
|
Do you mind if I take a day or 2 to look this over? I need to allocate a solid amount of time for this that I don't have at the moment. |
|
Not at all, take your time. |
|
I just realized I hadn't actually correctly implemented |
|
What do you mean? The code seemed true to its description, which is being like |
|
This line should have |
|
Yeah but IIRC that line only controls whether you get a verbose warning about being unsafe. Locking code wasn't generated in |
|
Oh, well we are also talking about different aspects of it. I guess the locking code was left in the startup/shutdown procedures with |
|
You're right again, still loading this code into context. |
See the commit message in the first commit.
Note that whatever race condition may have existed here: rleonid@dbe8a84#diff-d347ee27660b0e186d9f79a1f8950eb1R44 might not exist anymore, because that code is now only called by
at_exit, instead of on every unsafe mark.