Support testing under both 4.03 and 4.02 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, warnings end up mixed in with -dsource output. This makes it difficult to compare -dsource output with output of Pprintast, which never includes warnings. Warnings should be handled separately in testing. This will be taken care of in a future commit.
Reference files that are compared against -dsource output are now first parsed and printed (as if by -dsource). The re-printed output is then used to compare against -dsource output. This should make the comparison resistant against formatting changes in -dsource between compiler versions.
These are represented as top-level expressions in 4.02, but bindings in 4.03. The difference was causing spurious failures in report testing.
aantron
added a commit
that referenced
this pull request
Jun 17, 2016
The match expression rewriter inserts expressions that can cause spurious warnings. These warnings would be especially surprising to a user, because they would be coming from generated code. The test checks that these warnings are properly suppressed. We were checking this implicitly until #92. Closes #94.
aantron
added a commit
that referenced
this pull request
Jun 17, 2016
The match expression rewriter inserts expressions that can cause spurious warnings. These warnings would be especially surprising to a user, because they would be coming from generated code. The test checks that these warnings are properly suppressed. We were checking this implicitly until #92. Closes #94.
aantron
added a commit
that referenced
this pull request
Jun 17, 2016
The match expression rewriter inserts expressions that can cause spurious warnings. These warnings would be especially surprising to a user, because they would be coming from unseen generated code. The new tests check that these warnings are properly suppressed. We were checking this implicitly until #92. Closes #94.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This abstracts the compiler version away somewhat from the testing framework, mainly by running reference files through the OCaml parser, and then printing the AST as source using
Pprintast. Diffs are then run against these re-printed reference files.Resolves #91.
Some of the tests implicitly checked for the absence of warnings, because warnings were printed to
STDERRtogether with the output of-dsource. They are no longer printed, so we will have to write separate tests for warnings later.