Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground CSS improvements #109

Merged
merged 2 commits into from Jul 5, 2021
Merged

Playground CSS improvements #109

merged 2 commits into from Jul 5, 2021

Conversation

thangngoc89
Copy link
Contributor

@thangngoc89 thangngoc89 commented Jul 5, 2021

This PR addresses #105 in attempt to make the playground looks nicer.
Things done:

  • Vertically aligned headers and items inside it
  • Change Run button color + add border radius

All numbers are based on scale of 4px.

A picture is better than a thousand words so here we go:

image

This PR addresses aantron#105 in attempt to make the playground looks nicer.
Things done:
- Vertically aligned headers and items inside it
- Change Run button color + add border radius

All numbers are based on scale of 4px
@aantron
Copy link
Owner

aantron commented Jul 5, 2021

Thanks! Thsi branch is live now. Except for the thing with the link, it's ready to merge.

@thangngoc89
Copy link
Contributor Author

@aantron I updated that. It looks just like before :

image

@aantron
Copy link
Owner

aantron commented Jul 5, 2021

It looks misaligned now that everything is aligned :) Or would you prefer to keep it that way in this PR?

@aantron aantron merged commit 8b33007 into aantron:master Jul 5, 2021
@aantron
Copy link
Owner

aantron commented Jul 5, 2021

Alright, so it's actually aligned with the button, but because of the button colors, the eye wants the baseline of the link to be aligned with the baseline of the title. That can just be "fixed" later or ignored. Thanks!

@thangngoc89
Copy link
Contributor Author

Run and Docs for this example are actually aligned but it looks misaligned because of the color illusion. I think we would need to design this in a design program to see how things go. It's easier to move things around by drag and drop then write css code.

image

@thangngoc89 thangngoc89 deleted the patch-1 branch July 5, 2021 19:43
@aantron
Copy link
Owner

aantron commented Jul 5, 2021

It's now live and already looks considerably better. I guess even the button alone is like 10% of the UI or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants