Implement WebSockets on top of the new streams #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, the convenience readers need to be last, so that they can respond to ping with pong automatically.
Close codes still can't be received due to limitations of the websocket/af API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from changing the underlying abstraction, this also:
FINbit, ping and pong frames, and receiving the text/binary message flag to the Dream user (when using the lowest-level stream APIs; high-level convenience APIs don't still hide this). Receiving the text/binary bit is usually not relevant for the server, but may be relevant for some native clients that are not using UTF-8 for whatever reason.The Dream API is largely unchanged, it is just reimplemented using Stream. The API will be tweaked in follow-on PRs.