Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esy dependencies to enable VSCode intellisense #65

Merged
merged 2 commits into from May 31, 2021
Merged

Add esy dependencies to enable VSCode intellisense #65

merged 2 commits into from May 31, 2021

Conversation

dangdennis
Copy link
Contributor

@dangdennis dangdennis commented May 30, 2021

Changes

Added the necessary dependencies to enable VSCode intellisense for example 2-middleware.

Notes

  • In addition to installing these dependencies, must open each example in their own VSCode root project.
  • To use ./quickstart, Mac users must run chmod +x ./quickstart to be able to run the startup script.

@aantron I believe you should add the two bulletpoints somewhere to help beginners onboard as well.

Hope this PR helps ya, if not actual merge, at least for some user feedback 馃槅

@aantron aantron merged commit 6f472aa into aantron:master May 31, 2021
@aantron
Copy link
Owner

aantron commented May 31, 2021

Thanks! I will copy to other esy.json files (with credit), address the notes, and ping this PR when done.

aantron added a commit that referenced this pull request May 31, 2021
aantron added a commit that referenced this pull request May 31, 2021
Follow-on to 6f472aa. See #65.

Co-authored-by: Dennis Dang <dangggdennis@gmail.com>
@dangdennis dangdennis deleted the feat/add-ocaml-lsp-esy branch May 31, 2021 06:03
aantron added a commit that referenced this pull request May 31, 2021
@aantron
Copy link
Owner

aantron commented May 31, 2021

Should be all done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants