Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install headers for the vendored libuv #83

Closed
aantron opened this issue Oct 20, 2020 · 1 comment
Closed

Install headers for the vendored libuv #83

aantron opened this issue Oct 20, 2020 · 1 comment

Comments

@aantron
Copy link
Owner

aantron commented Oct 20, 2020

See https://dune.readthedocs.io/en/stable/foreign-code.html?highlight=install%20headers#installing-header-files.

cc @ulrikstrid

@aantron
Copy link
Owner Author

aantron commented Oct 20, 2020

The linked commit installs all the libuv headers into Luv's installation directory. It is enough to have (libraries luv) to be able to use #include <uv.h>.

There is a generator for the installation stanzas on the Luv side, which is integrated into the libuv upgrade script.

The commit also adds a test consisting of a toy project that depends on Luv and does #include <uv.h>. I set it up to run in Travis. I tested it locally with uv.h renamed to uvv.h to prevent the test from falsely succeeding by picking up a system uv.h. I opened #84 to later check if Travis has any system uv.h installed, and sabotage it during the test, if it is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant