Use ctypes field #146
Draft
Use ctypes field #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is not a complete port, but it's enough to get it working in a monorepo. The main thing it does is use the ctypes stanza to find the headers for ctypes. It uses a new version of the ctypes support that fixes some issue with paths to vendored headers.
Some remarks:
LUV_USE_SYSTEM_LIBUVto use a "plain" dune file, but this can be adapted to work with it. We can also discuss what's missing in dune to support that configuration variable.test/headersis not fully working. in particular a cold dune build will fail on this (but I'm not sure it's worse that the previous situation)