Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tree_with_loc and trees_with_loc #71

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

craff
Copy link

@craff craff commented Jun 30, 2023

Solves issue #70

@craff
Copy link
Author

craff commented Jun 30, 2023

I tried to fix/update the github workflow. I think it is now OK (not sure),
but there are some opam download that fails, even after I added opam update !

@craff craff mentioned this pull request Jul 4, 2023
Copy link
Owner

@aantron aantron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a few nits, all of which I can apply myself -- please let me know!

src/markup.ml Outdated Show resolved Hide resolved
src/markup.mli Show resolved Hide resolved
src/utility.ml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@craff
Copy link
Author

craff commented Jul 17, 2023

Am I supposed to do something for the coverage ?

@aantron
Copy link
Owner

aantron commented Jul 17, 2023

Am I supposed to do something for the coverage ?

Not necessary, unless you'd like to write some nice test cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants