-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix enrollment issues and bump library versions (#438) #439
Conversation
* Fix 403 and add automation for release * Prepare for release 4.1.4
Great work |
@@ -1,8 +1,8 @@ | |||
aiohttp[speedups]==3.8.1 | |||
aiohttp[speedups]==3.8.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aiohttp[speedups]==3.8.4
aiohttp[speedups]>=3.8.4
unless we want to manually do updates every major release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tied to specific versions as leaving it open has broken the script in the past
@@ -28,13 +28,13 @@ | |||
), | |||
python_requires=">=3.8, <4", | |||
install_requires=[ | |||
"aiohttp[speedups]==3.8.1", | |||
"aiohttp[speedups]==3.8.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aiohttp[speedups]==3.8.4
aiohttp[speedups]>=3.8.4
unless we want to manually do updates every major release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above. It might be worth looking into but generally we won't benefit from taking the latest version of libraries unless they fix an issue we have
Finally releasing 🙈 |
Fix 403 and add automation for release
Prepare for release 4.1.4
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: