Avoid extraneous call for DrawSelect in case of a zoom
#594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Document::Zoom(int, wxDC&, bool, bool)` calls `Document::DrawSelectMove(wxDC&, Selection&, bool, bool)` which calls `Document::DrawSelect(wxDC&, Selection&, bool, bool)`. So in this case, we do not need to call `Document::DrawSelect(wxDC&, Selection&, bool, bool)` again.
tobiolo
changed the title
DrawSelect in case of a zoom
This was referenced Jan 15, 2024
|
Are you aware that at least on Windows the selection is drawn as a XOR operation (i.e. invert pixels), meaning that drawing it a second time undoes the drawing? Which is faster than redrawing the entire screen. |
I am aware of this, yes. Unfortunately we have to stick with |
|
So does this change work well on Windows? |
I tested it on Windows and it works well. In |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document::Zoom(int, wxDC&, bool, bool)callsDocument::DrawSelectMove(wxDC&, Selection&, bool, bool)which callsDocument::DrawSelect(wxDC&, Selection&, bool, bool). So in this case, we do not need to callDocument::DrawSelect(wxDC&, Selection&, bool, bool)again.