change detection of audio to use sdk instead of pulseaudio #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroedl
force-pushed
the
use_jabrasdk_to_detect_audio
branch
from
56493c1
to
5584edc
Compare
|
Hi @danielroedl Thanks for your PR, I tested it work fine in my case too with pulseaudio. I will merge it. |
|
Hi @danielroedl Do you know if Jabra expose this kind of information ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I have no pulseaudio on my system
jabra-busylightwas not working.I noticed that the JabraSDK provides an event when audio emitting starts and stops.
So I change the code to use this.
I don't know if there is a cause why you did use pulseaudio instead. Is there a cause?