Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaFact tests not being discovered in .net core 3.0 using xUnit 2.4.0 and "dotnet.exe xunit.console.dll" #14

Closed
AdamYoblick opened this issue Oct 9, 2018 · 6 comments
Assignees

Comments

@AdamYoblick
Copy link

I already contacted you about this but I figured I'd create an issue so it can be tracked.

I'm building windows forms using .net core 3.0 from github and I have some tests using xUnit. A few of our tests need STA, so I tried using [StaFact] but it seems the test discovery is not working for me and I'm not sure why.

@AArnott
Copy link
Owner

AArnott commented Oct 10, 2018

I think this would work if you used xunit 2.3.1 instead of 2.4.0.
But #15 makes it work with xunit 2.4.0.

@AdamYoblick
Copy link
Author

Thank you Andrew, can you please let me know when a new nuget package is available with this change so we can test it in our build?

@AArnott
Copy link
Owner

AArnott commented Oct 10, 2018

It's available now as 0.3.2.

@AdamYoblick
Copy link
Author

Consumed the package and it worked like a charm. Thanks again :)

@Serg046
Copy link
Contributor

Serg046 commented Jan 11, 2019

The same issue for .net 4.5 and xunit 2.4.1
I was forced to migrate into .net 4.6 for tests

@AArnott
Copy link
Owner

AArnott commented Jan 16, 2019

How very curious. Sorry to hear of the trouble @Serg046 , but I'm glad you found a workaround.

AArnott added a commit that referenced this issue Jan 5, 2023
And a few path manipulating msbuild properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants