Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoHotKey-Support #278

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

GitNeph
Copy link

@GitNeph GitNeph commented Oct 15, 2020

  • Added Language to README
  • Added comment style to parser.ts
  • Added activation event to package.json

+ Added Language to README
+ Added comment style to parser.ts
+ Added activation event to package.json
@@ -251,6 +251,10 @@ export class Parser {
break;

case "apex":
Copy link

@JamesO2x JamesO2x Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. case "apex": is grouped together with the cases for javascript and typescript because it uses the same // syntax for comments. Placing case "ahk": below it here breaks support for apex.

You need to include the entire AHK case block above the case "apex": line (line 253).

Suggested change
case "apex":
case "ahk":
this.setCommentFormat(";", "/*", "*/");
break;
case "apex":
case "javascript":
case "javascriptreact":
case "typescript":
case "typescriptreact":
this.setCommentFormat("//", "/*", "*/");
this.highlightJSDoc = true;
break;

(This is my first suggestion on GitHub, so I hope I got the formatting right. Let me know if anything is unclear.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants