Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type validation and some brief descriptions for better-comments.tags (configuration of the extension) #400

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Take-Me1010
Copy link

Hello, the extension better-comments is really useful and I have used it for 2 years! Thanks!!

This PR includes JSON schema and some brief descriptions for configurations of better-comments.tags.
This PR will allow users to more easily review and customize the settings of tags!

In the schema, the properties required are tag, color, and backgroundColor because these properties seem essential in the source code. If not correct, I will modify it.

@Take-Me1010
Copy link
Author

for the property color, we can set not only #FFFFFF like style but also #FFFFFFAA or #RGB styles.
I found that in vscode theme color...

So this PR need to reflect them.

In addition, the properties color and backgroundColor seem not to be required. I will modify them in a day or so.

@Take-Me1010
Copy link
Author

Now I modified color validation.
In addition, only tag property is made required.
Please consider merging. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant