Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QueryPair object, improve __repr__ #20

Merged
merged 8 commits into from
Nov 7, 2018
Merged

Add QueryPair object, improve __repr__ #20

merged 8 commits into from
Nov 7, 2018

Conversation

alecraso
Copy link
Owner

@alecraso alecraso commented Nov 5, 2018

Changelist

  • QueryPair class created
    • Adds a layer of abstraction on the queries and databases that comparisons are run against
    • In particular, this allows for the "right" query to directly reference the output of the "left" query
  • ComparatorSet.from_list method removed
    • The logic was inherently complex and repetitive, and the from_dict method gives identical functionality that is much more explicit
  • All __repr__ strings improved to better follow convention and be generally more readable
  • DbConfig logging changed to DEBUG level
  • QueryResultCol class created
    • Improves abstraction on column of data from the QueryResult
    • Avoids iterating over entire result to just pull one key from each row
    • Gracefully handles unicode formatting issues in python 2
  • Adds tests to bring coverage back to 100%

@alecraso alecraso merged commit 9023079 into master Nov 7, 2018
@alecraso alecraso deleted the query-pair branch November 7, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant