Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -c DSCP codepoint option #83

Merged
merged 1 commit into from Apr 28, 2020
Merged

Add -c DSCP codepoint option #83

merged 1 commit into from Apr 28, 2020

Conversation

ldir-EDB0
Copy link
Contributor

Specify a DSCP codepoint on DNS server upstream connections. This may
be useful to those using qdiscs/AQMs that categorise traffic
importance/priority by DSCP value.

Whilst this could be done by ip/nftables rules, let's get the
application to do it.

Signed-off-by: Kevin Darbyshire-Bryant ldir@darbyshire-bryant.me.uk

src/https_client.c Outdated Show resolved Hide resolved
src/https_client.c Outdated Show resolved Hide resolved
Copy link
Owner

@aarond10 aarond10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Just two little nits.

@ldir-EDB0 ldir-EDB0 force-pushed the master branch 2 times, most recently from 3493c7e to cdbf15e Compare April 27, 2020 09:19
@ldir-EDB0
Copy link
Contributor Author

Updated the README.md file now as well :-)

@ldir-EDB0
Copy link
Contributor Author

Hold fire on this, may have just come across a mistake

Specify a DSCP codepoint on DNS server upstream connections.  This may
be useful to those using qdiscs/AQMs that categorise traffic
importance/priority by DSCP value.

Whilst this could be done by ip/nftables rules, let's get the
application to do it.

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
@ldir-EDB0
Copy link
Contributor Author

Fixed

@aarond10 aarond10 merged commit 232debd into aarond10:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants