This repository has been archived by the owner on Apr 27, 2020. It is now read-only.
Modify app glance #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CometDog
commented
Dec 5, 2016
CometDog
commented
- Added a toggle in configuration to turn app glance on and off
- Added a selector in configuration to choose between last session time and daily total time on app glance
- Disabled this selector if app glance toggle is turned off
- Added checks in the application to properly display the app glance based on the configuration screen
- Improperly localized everything (an issue can be created after merge)
- Added a toggle to turn the app glance on and off - Added a selector tool to choose to use the last session duration or current daily total - Disabled the selector tool if app glance is disabled - Still need to localize the strings (placeholders are set)
- Added the settings for app glance state and app glance type - Added an if-statement to either display the app glance or clear it completely
- Added new cases in localization for app glance strings
- Localization pending
- Added if-statement on deinit to decide which type of app glance to
display
- Added localization text via internet translation
- Will create an issue to properly translate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.