Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 11 support #45

Closed
jameswragg opened this issue May 3, 2020 · 3 comments
Closed

IE 11 support #45

jameswragg opened this issue May 3, 2020 · 3 comments

Comments

@jameswragg
Copy link

Realising a little late in the day that this library only supported IE 11 in the 3.x branch. I'm using the current 4.x release due to being able to apply install on an existing iframe - functionality required for my project 😫.

Before I dive in to it, is IE 11 support a matter of transpiling/polyfilling or is it entirely incompatible?

Thanks in advance

@Aaronius
Copy link
Owner

Aaronius commented May 3, 2020

Hey @jameswragg, I haven't tried running it on IE since 3.x, so I'm not sure how far off it is. If I were to guess, there's probably very little that needs to change beyond transpilation. If you find out, I'd be interested in knowing.

I noticed a fork of Penpal that has a commit that appears to be supporting IE: holidaycheck@1167808 By looking at the changes to the files in src, it looks like a couple very small tweaks.

@jameswragg
Copy link
Author

Really useful - thank you!

@Aaronius
Copy link
Owner

Aaronius commented May 8, 2020

@jameswragg If you've investigated this further, I'd like to hear about what you discovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants