[Question]: willing to make vterm into a separate lib?

[erikh]

I'm curious, I have a couple of tools which could benefit from a comprehensive virtual terminal.

Thanks!

[aaronjanse]

Absolutely! I plan on refactoring 3mux this week after receiving some helpful bug reports. I'll use that as an opportunity to make vterm usable on its own.

For the foreseeable future, I think most vterm bugs will be found through 3mux. It would be helpful to share an issue tracker between 3mux and vterm (with special tags to specify which of the two is broken).

For this reason, would it be okay if vterm remains under this repo, but importable on its own via github.com/aaronjanse/3mux/vterm?

Either way, I'll make sure vterm's gets some documentation love.

[erikh]

That’s perfect assuming it can be treated as public api. Happy to consume and patch it this way.

…

On Sun, Apr 12, 2020 at 2:28 PM Aaron Janse ***@***.***> wrote: Absolutely! I plan on refactoring 3mux this week after receiving some helpful bug reports. I'll use that as an opportunity to make vterm usable on its own. For the foreseeable future, I think most vterm bugs will be found through 3mux. It would be helpful to share an issue tracker between 3mux and vterm (with special tags to specify which of the two is broken). For this reason, would it be okay if vterm remains under this repo, but importable on its own via github.com/aaronjanse/3mux/vterm? Either way, I'll make sure vterm's gets some documentation love. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAET25CWQOI3PXHZEO3VODRMIXBPANCNFSM4MGSAHUA> .

[aaronjanse]

Does this sound good for a rough idea for a vterm API?

• rune channel for input
• interface for rendering output (color, set char at position, etc)

[dehorsley]

This would be great! May I suggest using a Write function to accept input, rather than a channel. That way it can satisfy io.Writer interface and users of your library can combine it with other standard library functions (like io.Copy) and 3rd party libraries.

[aaronjanse]

I've already got you covered 😉

3mux/vterm/stdout.go

Line 30 in 4389436

func (v *VTerm) ProcessStdout(input *bufio.Reader) {

[aaronjanse]

A not-yet-stable vterm package is available in v0.3.0. See fuzz/main.go for example usage.

[erikh]

Thanks for putting this together!

…

On Fri, Apr 24, 2020 at 11:28 AM Aaron Janse ***@***.***> wrote: A not-yet-stable vterm package is available in v0.3.0. See fuzz/main.go for example usage. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAET25BIXJEPRHI7LLYZMLROHK4JANCNFSM4MGSAHUA> .