Reduce large amount of unneeded writing to stdout #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PotatoParser
requested changes
Sep 28, 2020
|
Whoops, good catch! Those |
PotatoParser
approved these changes
Sep 28, 2020
aaronjanse
force-pushed
the
aj2020sep-recognize-charset-command
branch
from
0fe5134
to
99da7bb
Compare
ColorNone means that the default colors should be used, meaning Code is meaningless. Two ColorNones with different Codes are identical but previously were not treated as such.
aaronjanse
force-pushed
the
aj2020sep-none-style-diff
branch
from
4e56891
to
198d30c
Compare
aaronjanse
changed the base branch from
aj2020sep-recognize-charset-command
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColorNone means that the default colors should be used, meaning Code is meaningless. Two ColorNones with different Codes are identical but previously were not treated as such, causing the renderer to very often (every 25 milliseconds) print reset color commands unnecessarily.
I bet this also means much less idle CPU usage, but I haven't tested this theory.