Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the conditional statement #4

Open
SorokinaIrinaVl opened this issue Feb 12, 2021 · 2 comments
Open

Bug in the conditional statement #4

SorokinaIrinaVl opened this issue Feb 12, 2021 · 2 comments

Comments

@SorokinaIrinaVl
Copy link

SorokinaIrinaVl commented Feb 12, 2021

Hello!
There is a bug in this place of code:
if(!( grep(/^$k/,@record_position) ))
For example, when record_position = [10 , 12, 24] and k is 1, then it doesn't work (because 10 is 1 and 0, I think).
The right version is:
if(!( grep(/^$k$/,@record_position) )).

@poethan
Copy link
Contributor

poethan commented Feb 13, 2021

thanks for the interest. I will have a look at it and respond to you. :)

@poethan
Copy link
Contributor

poethan commented Feb 27, 2021

Hello!
There is a bag in this place of code:
if(!( grep(/^$k/,@record_position) ))
For example, when record_position = [10 , 12, 24] and k is 1, then it doesn't work (because 10 is 1 and 0, I think).
The right version is:
if(!( grep(/^$k$/,@record_position) )).

When I wrote the code, I intended to record position of each word or token, instead of character level. i.e. I was trying to record position of each token(can be word or punctuation) according to the gap of space. The LEPOR metric measure the similarity between to sentences at word level, instead of character level. Does this help?

@SorokinaIrinaVl SorokinaIrinaVl changed the title Bag in the conditional statement Bug in the conditional statement Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants