Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organizers not returning false for success on context failure #60

Closed
aaronmallen opened this issue Sep 9, 2019 · 0 comments · Fixed by #61
Closed

Organizers not returning false for success on context failure #60

aaronmallen opened this issue Sep 9, 2019 · 0 comments · Fixed by #61
Labels
bug Something isn't working verified This issue has been verified.

Comments

@aaronmallen
Copy link
Owner

Current Behavior

Organizers are not accurately returning context success status

Expected Behavior

Organizers should not be successful on context failure

Steps to Reproduce

  1. Create an organizer
  2. Fail the context in the first interactor

Additional Comments
@aaronmallen aaronmallen added P4 verified This issue has been verified. bug Something isn't working labels Sep 9, 2019
@aaronmallen aaronmallen added this to the v0.1.7 milestone Sep 9, 2019
aaronmallen added a commit that referenced this issue Sep 10, 2019
@aaronmallen
#60: ensure organizers accurately report success
1b07581 
resolves #60
@aaronmallen aaronmallen mentioned this issue Sep 10, 2019
Merged
3 tasks
aaronmallen added a commit that referenced this issue Sep 10, 2019
@aaronmallen
#60: ensure organizers accurately report success (#61)
74521d6 
resolves #60
aaronmallen added a commit that referenced this issue Sep 10, 2019
@aaronmallen
v0.1.7 release canidate (#63)
91aabf8 
* removed ActiveInteractor::Context::Failure (#42)

* lowered method complexity and enforced single responsibility (#44)

* Update simplecov to version 0.17.0 (#46)

* Update rubocop to version 0.73.0 (#49)

* Update rake: 12.3.2 → 12.3.3 (patch) (#52)

* add directory argument to install generator (#54)

* Update redcarpet to version 3.5.0 (#57)

* Update rubocop to version 0.74.0 (#58)

* Update all of rails to version 6.0.0 (#59)

* #60: ensure organizers accurately report success (#61)

resolves #60

* generate v0.1.7 release (#62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working verified This issue has been verified.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#60: ensure organizers accurately report success aaronmallen/activeinteractor
1 participant
@aaronmallen