Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow undefined optional attributes to be set internally #245

Merged
merged 4 commits into from
Oct 4, 2020
Merged

Allow undefined optional attributes to be set internally #245

merged 4 commits into from
Oct 4, 2020

Conversation

aka-momo
Copy link
Contributor

@aka-momo aka-momo commented Oct 2, 2020

Description

Undefined optional attributes not being updated (on external context) from internal interactors.

Information

  • Contains Documentation
  • Contains Tests
  • Contains Breaking Changes

Related Issues

Changelog

Added

  • ActiveInteractor::Context::Attributes#[]= to set Hash attributes in ActiveInteractor::Context::Attributes#attributes

Changed

  • ActiveInteractor::Context::Attributes#merge! to use attributes from both ActiveInteractor::Context::Attributes#attributes and ActiveInteractor::Context::Attributes#to_h

Fixed

@aaronmallen
Copy link
Owner

Thank you again for the PR @mohameddiaa27

@aaronmallen aaronmallen merged commit 9e059b2 into aaronmallen:main Oct 4, 2020
@aaronmallen aaronmallen added this to the v1.1.0 milestone Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmallen aaronmallen aaronmallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aka-momo @aaronmallen