Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to share build via link #16

Closed
aaronmaynard opened this issue Jan 8, 2018 · 2 comments · Fixed by #17
Closed

Add the ability to share build via link #16

aaronmaynard opened this issue Jan 8, 2018 · 2 comments · Fixed by #17

Comments

@aaronmaynard
Copy link
Owner

aaronmaynard commented Jan 8, 2018

🥇 first-timers-only

This issue is tagged :octocat: first-timers-only. It is only for people who have never contributed to open source before and are looking for an easy way take their first steps.

Consider this as your chance to dip your toe into the world of open-source and get some bragging rights for writing code that makes drones fly, cars find charging stations, helps people and goods move from place to place and more...

Thank you for your help ❤️

📋 Issue:

You will be adding an alternate option to saving the script generated by the user via the graphical interface. This is pretty simple... you will be creating a button that will be used to grab the window location (URL) and allowing them to easily share their build with their friends via social media or other means. This is laying the foundation for what will later be URL shortening. Apply your changes to index.html located in the root directory.

🍎 Approach:

Add this button to the <div class="dropdown-content"> element. Follow the current formula for the interface by using a <span> element and the appropriate class="className". The text should read: "NEW Share Online", without quotes, and "new" being in color:orange. When clicking on the button the user should be prompted to "Copy this link to share your build:" and be given the URL generated by the canvas.

Inline Styling:

<p style="color:blue;">This is a Styled Paragraph</p>

Browser Prompting:

onclick="prompt(text, defaultText)"

Element Classes:

<element class="someClass">Some Stuff</element>

JavaScript Window Location:

window.location.assign loads a new document
window.location.hostname returns the domain name of the web host
window.location.href returns the href (URL) of the current page
window.location.pathname returns the path and filename of the current page
window.location.protocol returns the web protocol used (http or https)

👥 Contributing:

  • Comment in this issue that you would like to do it.
  • Open the Skyrim-Perk-Utility GitHub page and click the ★ Star and then ⑂ Fork buttons.
  • Once you've made sure all your changes work correctly and committed all your changes,
  • Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/Skyrim-Perk-Utility) and create a pull request for your changes.
  • Make sure your pull request describes exactly what you changed and references this issue (include the issue number in the title like this: Add the ability to share build via link #16)
  • Please do not fix more than one issue at a time. Your pull request should only fix what is described in this issue.

🆘 Asking for help

We appreciate your effort in taking the time to work on this issue and help out the open source community.
If you need any help, feel free to ask below. We are always happy to help 😄

@pacbac
Copy link
Contributor

pacbac commented Jan 8, 2018

Hi, can I start to try working on this?

@aaronmaynard
Copy link
Owner Author

@pacbac go for it! Good luck 😄

@aaronmaynard aaronmaynard added this to Done in User Interface Jan 10, 2018
@aaronmaynard aaronmaynard moved this from Completed to Merged in User Interface Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
User Interface
Merged to Server
Development

Successfully merging a pull request may close this issue.

2 participants