Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version number is returned for Veracrypt #166

Closed
AshleyHow opened this issue May 21, 2021 · 2 comments
Closed

Incorrect version number is returned for Veracrypt #166

AshleyHow opened this issue May 21, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AshleyHow
Copy link
Contributor

First of all I want to thank you for adding the app to evergreen.

I've gone to test it today and noticed that the version being reported is '1.24' (an older version) when it should be '1.24-Update7'.

@aaronparker
Copy link
Owner

Yep, VeraCrypt's versioning system sucks.

It returns the right executables though. I'll have to update the RegEx at some point to capture the version number. Or create a PR that updates the RegEx here: https://github.com/aaronparker/Evergreen/blob/2e2af8082151dec18ef059dd6e29b73e2ee48cf4/Evergreen/Manifests/VeraCrypt.json#L21

@aaronparker aaronparker added the enhancement New feature or request label May 21, 2021
@aaronparker aaronparker added this to To do in Updates and Fixes via automation May 21, 2021
@aaronparker aaronparker added the good first issue Good for newcomers label May 21, 2021
@AshleyHow
Copy link
Contributor Author

Resolved in latest release from my pull request.

Updates and Fixes automation moved this from To do to Done Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Development

No branches or pull requests

2 participants