Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on me in the callback URL #79

Closed
aaronpk opened this issue Jul 1, 2017 · 3 comments
Closed

Don't rely on me in the callback URL #79

aaronpk opened this issue Jul 1, 2017 · 3 comments

Comments

@aaronpk
Copy link
Owner

aaronpk commented Jul 1, 2017

should get the me from the session to avoid being tricked into exchanging the auth code at some other server

@cweiske
Copy link
Contributor

cweiske commented Aug 18, 2017

This breaks https://commentpara.de, which hands out different user URLs depending on their login.

You input https://commentpara.de/ as URL, and the auth endpoint returns https://commentpara.de/user/3.htm

@aaronpk
Copy link
Owner Author

aaronpk commented Aug 18, 2017

@cweiske This is just about not using the me returned in the callback URL. Quill still uses the me returned from the POST request that gets an access token. It looks like commentpara.de is returning me=https://commentpara.de/ in the response but it should actually return the unique user URL for the user who logged in. cweiske/anoweco#3

@cweiske
Copy link
Contributor

cweiske commented Aug 18, 2017

For reference: Taking "me" from the callback is not secure because the user could change/forge that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants