Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker heroku deploy button #43

Conversation

Lewiscowles1986
Copy link
Contributor

@Lewiscowles1986 Lewiscowles1986 commented Aug 17, 2019

A series of edits to enable heroku deploys from a button.

  • supports multiple MySQL providers (tested on Heroku) [REMOVED]
  • brings local-dev docker-compose environment
  • makes redis URL configurable (compatible with Heroku) [MOVED TO Healthcheck endpoint #46]
  • adds healthcheck endpoint to verify can talk to mysql & redis (not schema check or OAUTH provider check) [MOVED TO Healthcheck endpoint #46]
  • css frontend fix to stop horizontal scrollbars (footer margin) [MOVED TO Fix FE CSS for footer #45]
  • replaced short tags that do not output <? with <?php [MOVED TO Convert non-output short-tags to full tags #49]
  • This has been tested with multiple Heroku DB providers as well as locally in a docker + docker-compose local-dev environment

Could do with a clean-up, test suite, change or removal of config.php [DONE]

@Lewiscowles1986
Copy link
Contributor Author

Lewiscowles1986 commented Aug 17, 2019

Local Docker homepage

Screenshot from 2019-08-17 22-34-52

@Lewiscowles1986
Copy link
Contributor Author

Lewiscowles1986 commented Aug 17, 2019

Heroku deploy homepage

Screenshot from 2019-08-17 22-30-41

Heroku deploy other pages

Screenshot from 2019-08-17 22-32-32

Screenshot from 2019-08-17 22-33-23
Screenshot from 2019-08-17 22-33-03
Screenshot from 2019-08-17 22-32-40

Screenshot from 2019-08-17 22-30-55
Screenshot from 2019-08-17 22-30-47

@Lewiscowles1986
Copy link
Contributor Author

Lewiscowles1986 commented Aug 17, 2019

I have not yet worked out the MySQL migrations needed to manage from a raw SQL file on Heroku. I have tested locally and you'll notice a Docker compose MySQL container option because of changes to MySQL auth, which are not yet in PHP PDO at the time of writing.

It's likely that heroku provider specific instructions will differ between vendors

@Lewiscowles1986
Copy link
Contributor Author

healthcheck & CSS changes have been removed and moved into their own PR

@Lewiscowles1986
Copy link
Contributor Author

For now this is blocked on the inclusion of 12-factor PR's #47 or a config.php commit (of which I'd strongly recommend one that uses ENV).

I've reduced it's size and functionality to provide a pick-and-mix style approach to docker and heroku setup. This is pretty much now only a local docker environment (with docker-compose) and a heroku deploy.

@Lewiscowles1986
Copy link
Contributor Author

I need to check this again before it's committed.

@aaronpk
Copy link
Owner

aaronpk commented Jan 25, 2020

I've made the changes for config loading from environment variables so it should be possible now to finish this PR. I don't fully understand the current state of this PR though.

@Lewiscowles1986
Copy link
Contributor Author

Chopped into pieces. I'll test soon and get back to you 👍. Last I checked I was waiting on you to explore an alternative ENV loader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants