New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker heroku deploy button #43
Docker heroku deploy button #43
Conversation
I have not yet worked out the MySQL migrations needed to manage from a raw SQL file on Heroku. I have tested locally and you'll notice a Docker compose MySQL container option because of changes to MySQL auth, which are not yet in PHP PDO at the time of writing. It's likely that heroku provider specific instructions will differ between vendors |
d8fbe01
to
c1892b7
Compare
healthcheck & CSS changes have been removed and moved into their own PR |
df1746e
to
727a5ad
Compare
For now this is blocked on the inclusion of 12-factor PR's #47 or a I've reduced it's size and functionality to provide a pick-and-mix style approach to docker and heroku setup. This is pretty much now only a local docker environment (with docker-compose) and a heroku deploy. |
727a5ad
to
8322911
Compare
800a03c
to
e40f37a
Compare
I need to check this again before it's committed. |
I've made the changes for config loading from environment variables so it should be possible now to finish this PR. I don't fully understand the current state of this PR though. |
Chopped into pieces. I'll test soon and get back to you 👍. Last I checked I was waiting on you to explore an alternative ENV loader |
e40f37a
to
af54aa4
Compare
A series of edits to enable heroku deploys from a button.
supports multiple MySQL providers (tested on Heroku)[REMOVED]makes redis URL configurable (compatible with Heroku)[MOVED TO Healthcheck endpoint #46]adds healthcheck endpoint to verify can talk to mysql & redis (not schema check or OAUTH provider check)[MOVED TO Healthcheck endpoint #46]css frontend fix to stop horizontal scrollbars (footer margin)[MOVED TO Fix FE CSS for footer #45]replaced short tags that do not output[MOVED TO Convert non-output short-tags to full tags #49]<?
with<?php
Could do with a clean-up, test suite, change or removal of config.php[DONE]