Update section on authorization code binding #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed update based on feedback in issue #47 Open question for reviewers (and @bc_pi) whether we should allow both or only a single method, and if a single methods should we opt for the least common denominator (dpop_jkt) or an authorization challenge endpoint specific one?
|
Commented over in #47 that I think the single method of the DPoP proof header is sufficient and preferred. |
gffletch
approved these changes
Feb 21, 2024
|
I would tend to agree that we should stick with only the header option for DPoP. |
|
I'm good with that. Will create a PR to reflect this.
…On Fri 23 Feb 2024, 16:24 Aaron Parecki, ***@***.***> wrote:
I would tend to agree that we should stick with *only* the header option
for DPoP.
—
Reply to this email directly, view it on GitHub
<#59 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVT5JWNVDSOA2S7ALO24S2TYVC7FHAVCNFSM6AAAAABDPTPJPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGYZDMMJSGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Simplified based on feedback from Brian and Aaron.
bc-pi
reviewed
Feb 26, 2024
bc-pi
approved these changes
Feb 26, 2024
aaronpk
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed update based on feedback in issue #47
Open question for reviewers (and @bc_pi) whether we should allow both or only a single method, and if a single methods should we opt for the least common denominator (dpop_jkt) or an authorization challenge endpoint specific one?