Track redirects followed by curl #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURLOPT_HEADERFUNCTION is the recommended method for collecting the response headers. Because every request in the redirect chain contains headers (at the minimum a location line), we can track which URL’s headers are being parsed and collect a history of URLs.
Rebuild the debug property from the raw headers passed to the new CURLOPT_HEADERFUNCTION and the response body. This will match the raw HTTP response more than previously. It will also contain all the redirecting steps and HTTP status lines.
Taking the format that @aaronpk has used for aaronpk/IndieLogin.com. Also make sure the redirect array gets cleared at the first request, just in case the transport object is reused.
|
To clarify, the only API change is that if Curl is used as the transport system the output will contain 1 extra key in the array: I’ll do another commit with an updated README. |
|
Hopefully that README change clears things up, @aaronpk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three commits:
Implement a
CURLOPT_HEADERFUNCTIONthat keeps track of all headers coming in, and when curl switches to a different URL logs this as a redirect.Reimplement the
debugproperty coming out of the transport, because theCURLOPT_HEADERFUNCTIONtook all headers away from the standard response. As all lines parsed by the header function can be added to debug now, it will actually show all responses (with their headers) along the redirect path. In a way it has become even more complete.Use the syntax expected by aaronpk/indielogin.com for the redirect array:
All of this is also detailed in the commit messages.