Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a singleton Azure Cosmos DB client for the lifetime of your application #42

Closed
travis-leith opened this issue Oct 4, 2020 · 3 comments

Comments

@travis-leith
Copy link

The official performance guidance (at least for v3 SDK) is to keep a single client for the lifetime of the app.

I think this library should either implement the singleton pattern, or provide an argument to execAsync that takes in the client.

Unless, of course, this advice is no longer relevant for v4. I could not find a similar page for v4.

@travis-leith
Copy link
Author

I'd like to submit a PR to address this but because of an Ionide issue you are already aware of, I cannot get it to build with the Analyzer. Perhaps this should wait until Ionide upgrade their dependencies?

@aaronpowell
Copy link
Owner

I assume it's the same guidance for v4, I've reached out to the team for clarity

@aaronpowell
Copy link
Owner

This will be coming in v1, check out #54 for more about v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants