New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with incorrect counting of linebreaks in textarea #24

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@borNfreee

borNfreee commented Oct 25, 2013

There is bug in FF, Chrome when linebreak is treated as 1 symbol when it's actually 2 symbols.

Because of this bug with such configuration:

<textarea maxlength="4">ff
f
</textarea>

browser does not allow us to enter more letters, but at the same time simplyCounter shows "you can enter 1 letter".

So this PR fixes this problem.

@aaronrussell please review, this is a major bug

borNfreee added some commits Oct 25, 2013

Fixed bug with incorrect counting of linebreaks in textarea
There is bug in FF, Chrome when linebreak is treated as 1 symbol when it's actually 2 symbols.

Because of this bug with such configuration:
```
<textarea maxlength="4">ff
f
</textarea>
```
browser does not allow us to enter more letters, but at the same time `simplyCounter` shows "you can enter *1* letter".

So this PR fixes this problem.
@borNfreee

This comment has been minimized.

Show comment
Hide comment
@borNfreee

borNfreee Sep 15, 2014

@aaronrussell any chance to merge?

borNfreee commented Sep 15, 2014

@aaronrussell any chance to merge?

@borNfreee

This comment has been minimized.

Show comment
Hide comment
@borNfreee

borNfreee commented Jun 27, 2018

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment