Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI runs #808

Merged
merged 7 commits into from
May 8, 2023
Merged

Fix CI runs #808

merged 7 commits into from
May 8, 2023

Conversation

stonedDiscord
Copy link
Contributor

Types of changes

Fix the CI runs that seem to be broken.
It runs the dotnet build check on ubuntu to make it obvious when a change is introduced that doesn't compile. (takes about 2:30m)
It runs the CodeQL check on Windows, which includes a build check, to see if it builds on both platforms.
From experience i also know that Windows runners usually take longer to pick up a job, which makes less of an impact with the long runtime CodeQL takes. (takes about 22:30m)

It also runs the checks on all branches, this makes it very obvious in a feature branch when a breaking change was intoduced.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New filesystem, test images in [url]
  • New media image, test images in [url]
  • New partition scheme, test images in [url]
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project. (there is no code)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes. (this is the test)
  • All new and existing tests passed.

@claunia claunia merged commit 65b0ebd into aaru-dps:devel May 8, 2023
2 of 3 checks passed
@stonedDiscord stonedDiscord deleted the ci-run branch May 9, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants