Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3] Fix AASd-116 #271

Merged
merged 1 commit into from
Jun 2, 2023
Merged

[V3] Fix AASd-116 #271

merged 1 commit into from
Jun 2, 2023

Conversation

mristin
Copy link
Contributor

@mristin mristin commented Jun 1, 2023

We enforce global asset ID to be set if any of the specific asset IDs are set to globalAssetId. The text of the invariant is a bit ambiguous, so this has been discovered only eventually.

@mristin
[V3] Fix AASd-116
56bd354 
We enforce global asset ID to be set if any of the specific asset IDs
are set to `globalAssetId`. The text of the invariant is a bit
ambiguous, so this has been discovered only eventually.
zrgt
zrgt approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@zrgt zrgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If specificAssetId.name is "globalAssetId," AASd-116 indirectly states that global Asset ID must be set because the identifier in specificAssetId.value always exists whenever specific Asset ID is provided.

@mristin mristin merged commit 1424354 into main Jun 2, 2023
2 checks passed
@mristin mristin deleted the mristin/Enforce-global-asset-id-set-if-specific-asset-id-set-to-global-asset-id branch June 2, 2023 14:04
@mristin
Copy link
Contributor Author

mristin commented Jun 2, 2023

Thanks, @zrgt !

mristin added a commit to aas-core-works/aas-core-codegen that referenced this pull request Jun 9, 2023
@mristin
Make nullability checks stricter in type inference
3d15454 
We make `intermediate.type_inference` stricter w.r.t. nullability
(non-None) checks. This is motivated by bugs occurring in aas-core-meta,
such as [271], [272] and [273].

[271]: aas-core-works/aas-core-meta#271
[272]: aas-core-works/aas-core-meta#272
[273]: aas-core-works/aas-core-meta#273
mristin added a commit to aas-core-works/aas-core-codegen that referenced this pull request Jun 9, 2023
@mristin
Make nullability checks stricter in type inference
0e3de65 
We make `intermediate.type_inference` stricter w.r.t. nullability
(non-None) checks. This is motivated by bugs occurring in aas-core-meta,
such as [271], [272] and [273].

[271]: aas-core-works/aas-core-meta#271
[272]: aas-core-works/aas-core-meta#272
[273]: aas-core-works/aas-core-meta#273
@mristin mristin mentioned this pull request Jun 9, 2023
Merged
mristin added a commit to aas-core-works/aas-core-codegen that referenced this pull request Jun 9, 2023
@mristin
Make nullability checks stricter in type inference (#385)
28f498a 
We make `intermediate.type_inference` stricter w.r.t. nullability
(non-None) checks. This is motivated by bugs occurring in aas-core-meta,
such as [271], [272] and [273].

[271]: aas-core-works/aas-core-meta#271
[272]: aas-core-works/aas-core-meta#272
[273]: aas-core-works/aas-core-meta#273
mristin added a commit to aas-core-works/aas-core3.0-csharp that referenced this pull request Jun 24, 2023
@mristin
Update to aas-core-meta, codegen, testgen 44756fb, e2b793f, bf3720d7
9a1c466 
We update the development requirements to and re-generate everything
with:
* [aas-core-meta 44756fb],
* [aas-core-codegen e2b793f] and
* [aas-core3.0-testgen bf3720d7].

This is an important patch propagating in particular the following fixes
which affected the constraints and their documentation:

* Pull requests in aas-core-meta [#271], [#272] and [#273] which affect the
  nullability checks in constraints,
* Pull request in aas-core-meta [#275] which affects the documentation
  of many constraints.

This patch also includes a propagation of improved test data:

* Pull request in aas-core3.0-testgen [#12] which makes the
  errors in XML more meaningful and easier to debug, and
* Pull request in aas-core3.0-testgen [#13] which makes the type
  violations of enumerations more explicit and thus easier to debug.

[aas-core-meta 44756fb]: aas-core-works/aas-core-meta@44756fb
[aas-core-codegen e2b793f]: aas-core-works/aas-core-codegen@e2b793f
[aas-core3.0-testgen bf3720d7]: aas-core-works/aas-core3.0-testgen@bf3720d7

[#271]: aas-core-works/aas-core-meta#271
[#272]: aas-core-works/aas-core-meta#272
[#273]: aas-core-works/aas-core-meta#273
[#275]: aas-core-works/aas-core-meta#275

[#12]: aas-core-works/aas-core3.0-testgen#12
[#13]: aas-core-works/aas-core3.0-testgen#13
@mristin mristin mentioned this pull request Jun 24, 2023
Merged
mristin added a commit to aas-core-works/aas-core3.0-csharp that referenced this pull request Jun 24, 2023
@mristin
Update to aas-core-meta, codegen, testgen 44756fb, e2b793f, bf3720d7 (#…
0689460 
…18)

We update the development requirements to and re-generate everything
with:
* [aas-core-meta 44756fb],
* [aas-core-codegen e2b793f] and
* [aas-core3.0-testgen bf3720d7].

This is an important patch propagating in particular the following fixes
which affected the constraints and their documentation:

* Pull requests in aas-core-meta [#271], [#272] and [#273] which affect the
  nullability checks in constraints,
* Pull request in aas-core-meta [#275] which affects the documentation
  of many constraints.

This patch also includes a propagation of improved test data:

* Pull request in aas-core3.0-testgen [#12] which makes the
  errors in XML more meaningful and easier to debug, and
* Pull request in aas-core3.0-testgen [#13] which makes the type
  violations of enumerations more explicit and thus easier to debug.

[aas-core-meta 44756fb]: aas-core-works/aas-core-meta@44756fb
[aas-core-codegen e2b793f]: aas-core-works/aas-core-codegen@e2b793f
[aas-core3.0-testgen bf3720d7]: aas-core-works/aas-core3.0-testgen@bf3720d7

[#271]: aas-core-works/aas-core-meta#271
[#272]: aas-core-works/aas-core-meta#272
[#273]: aas-core-works/aas-core-meta#273
[#275]: aas-core-works/aas-core-meta#275

[#12]: aas-core-works/aas-core3.0-testgen#12
[#13]: aas-core-works/aas-core3.0-testgen#13
mristin added a commit to aas-core-works/aas-core3.0-python that referenced this pull request Jun 24, 2023
@mristin
Update to aas-core-meta, codegen, testgen 44756fb, 607f65c, bf3720d7
053e8ea 
We update the development requirements to and re-generate everything
with:
* [aas-core-meta 44756fb],
* [aas-core-codegen 607f65c] and
* [aas-core3.0-testgen bf3720d7].

This is an important patch propagating in particular the following fixes
which affected the constraints and their documentation:

* Pull requests in aas-core-meta [#271], [#272] and [#273] which affect the
  nullability checks in constraints,
* Pull request in aas-core-meta [#275] which affects the documentation
  of many constraints.

This patch also includes a propagation of improved test data:

* Pull request in aas-core3.0-testgen [#12] which makes the
  errors in XML more meaningful and easier to debug, and
* Pull request in aas-core3.0-testgen [#13] which makes the type
  violations of enumerations more explicit and thus easier to debug.

[aas-core-meta 44756fb]: aas-core-works/aas-core-meta@44756fb
[aas-core-codegen 607f65c]: aas-core-works/aas-core-codegen@607f65c
[aas-core3.0-testgen bf3720d7]: aas-core-works/aas-core3.0-testgen@bf3720d7

[#271]: aas-core-works/aas-core-meta#271
[#272]: aas-core-works/aas-core-meta#272
[#273]: aas-core-works/aas-core-meta#273
[#275]: aas-core-works/aas-core-meta#275

[#12]: aas-core-works/aas-core3.0-testgen#12
[#13]: aas-core-works/aas-core3.0-testgen#13
@mristin mristin mentioned this pull request Jun 24, 2023
Merged
mristin added a commit to aas-core-works/aas-core3.0-python that referenced this pull request Jun 24, 2023
@mristin
Update to aas-core-meta, codegen, testgen 44756fb, 607f65c, bf3720d7 (#7
2ef66b6 
)

We update the development requirements to and re-generate everything
with:
* [aas-core-meta 44756fb],
* [aas-core-codegen 607f65c] and
* [aas-core3.0-testgen bf3720d7].

This is an important patch propagating in particular the following fixes
which affected the constraints and their documentation:

* Pull requests in aas-core-meta [#271], [#272] and [#273] which affect the
  nullability checks in constraints,
* Pull request in aas-core-meta [#275] which affects the documentation
  of many constraints.

This patch also includes a propagation of improved test data:

* Pull request in aas-core3.0-testgen [#12] which makes the
  errors in XML more meaningful and easier to debug, and
* Pull request in aas-core3.0-testgen [#13] which makes the type
  violations of enumerations more explicit and thus easier to debug.

[aas-core-meta 44756fb]: aas-core-works/aas-core-meta@44756fb
[aas-core-codegen 607f65c]: aas-core-works/aas-core-codegen@607f65c
[aas-core3.0-testgen bf3720d7]: aas-core-works/aas-core3.0-testgen@bf3720d7

[#271]: aas-core-works/aas-core-meta#271
[#272]: aas-core-works/aas-core-meta#272
[#273]: aas-core-works/aas-core-meta#273
[#275]: aas-core-works/aas-core-meta#275

[#12]: aas-core-works/aas-core3.0-testgen#12
[#13]: aas-core-works/aas-core3.0-testgen#13
mristin added a commit to aas-core-works/aas-core3.0-typescript that referenced this pull request Jun 24, 2023
@mristin
Update to aas-core-meta, codegen, testgen 44756fb, 607f65c, bf3720d7
8ca55d9 
We update the development requirements to and re-generate everything
with:
* [aas-core-meta 44756fb],
* [aas-core-codegen 607f65c] and
* [aas-core3.0-testgen bf3720d7].

This is an important patch propagating in particular the following fixes
which affected the constraints and their documentation:

* Pull requests in aas-core-meta [#271], [#272] and [#273] which affect the
  nullability checks in constraints,
* Pull request in aas-core-meta [#275] which affects the documentation
  of many constraints.

This patch also includes a propagation of improved test data:

* Pull request in aas-core3.0-testgen [#13] which makes the type
  violations of enumerations more explicit and thus easier to debug.

[aas-core-meta 44756fb]: aas-core-works/aas-core-meta@44756fb
[aas-core-codegen 607f65c]: aas-core-works/aas-core-codegen@607f65c
[aas-core3.0-testgen bf3720d7]: aas-core-works/aas-core3.0-testgen@bf3720d7

[#271]: aas-core-works/aas-core-meta#271
[#272]: aas-core-works/aas-core-meta#272
[#273]: aas-core-works/aas-core-meta#273
[#275]: aas-core-works/aas-core-meta#275

[#13]: aas-core-works/aas-core3.0-testgen#13
@mristin mristin mentioned this pull request Jun 24, 2023
Merged
mristin added a commit to aas-core-works/aas-core3.0-typescript that referenced this pull request Jun 24, 2023
@mristin
Update to aas-core-meta, codegen, testgen 44756fb, 607f65c, bf3720d7 (#7
6dc9bc8 
)

We update the development requirements to and re-generate everything
with:
* [aas-core-meta 44756fb],
* [aas-core-codegen 607f65c] and
* [aas-core3.0-testgen bf3720d7].

This is an important patch propagating in particular the following fixes
which affected the constraints and their documentation:

* Pull requests in aas-core-meta [#271], [#272] and [#273] which affect the
  nullability checks in constraints,
* Pull request in aas-core-meta [#275] which affects the documentation
  of many constraints.

This patch also includes a propagation of improved test data:

* Pull request in aas-core3.0-testgen [#13] which makes the type
  violations of enumerations more explicit and thus easier to debug.

[aas-core-meta 44756fb]: aas-core-works/aas-core-meta@44756fb
[aas-core-codegen 607f65c]: aas-core-works/aas-core-codegen@607f65c
[aas-core3.0-testgen bf3720d7]: aas-core-works/aas-core3.0-testgen@bf3720d7

[#271]: aas-core-works/aas-core-meta#271
[#272]: aas-core-works/aas-core-meta#272
[#273]: aas-core-works/aas-core-meta#273
[#275]: aas-core-works/aas-core-meta#275

[#13]: aas-core-works/aas-core3.0-testgen#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrgt zrgt zrgt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mristin @zrgt