Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3] Fix messages for duplicate languages #301

Merged
merged 1 commit into from
Jan 26, 2024
Merged

[V3] Fix messages for duplicate languages #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions aas_core_meta/v3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,7 +1611,7 @@ def __init__(self, extensions: Optional[List["Extension"]] = None) -> None:
lambda self:
not (self.display_name is not None)
or lang_strings_have_unique_languages(self.display_name),
"Display name specifies no duplicate languages."
"Display name must specify unique languages."
)
@invariant(
lambda self:
Expand All @@ -1623,7 +1623,7 @@ def __init__(self, extensions: Optional[List["Extension"]] = None) -> None:
lambda self:
not (self.description is not None)
or lang_strings_have_unique_languages(self.description),
"Description specifies no duplicate languages."
"Description must specify unique languages."
)
@invariant(
lambda self:
Expand Down Expand Up @@ -3062,7 +3062,7 @@ def __init__(
lambda self:
not (self.value is not None)
or lang_strings_have_unique_languages(self.value),
"Value specifies no duplicate languages."
"Value must specify unique languages."
)
# fmt: on
class Multi_language_property(Data_element):
Expand Down Expand Up @@ -5501,7 +5501,7 @@ def is_BCP_47_for_english(text: str) -> bool:
@invariant(
lambda self:
lang_strings_have_unique_languages(self.preferred_name),
"Preferred name specifies no duplicate languages."
"Preferred name must specify unique languages."
)
@invariant(
lambda self:
Expand All @@ -5512,7 +5512,7 @@ def is_BCP_47_for_english(text: str) -> bool:
lambda self:
not (self.short_name is not None)
or lang_strings_have_unique_languages(self.short_name),
"Short name specifies no duplicate languages."
"Short name must specify unique languages."
)
@invariant(
lambda self:
Expand All @@ -5524,7 +5524,7 @@ def is_BCP_47_for_english(text: str) -> bool:
lambda self:
not (self.definition is not None)
or lang_strings_have_unique_languages(self.definition),
"Definition specifies no duplicate languages."
"Definition must specify unique languages."
)
@invariant(
lambda self:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_v3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1402,7 +1402,7 @@ def test_that_all_list_of_lang_strings_are_lang_string_sets(self) -> None:
# fmt: on

expected_description = (
f"{human_readable_prop_name} specifies no duplicate languages."
f"{human_readable_prop_name} must specify unique languages."
)

if invariant.description is None:
Expand Down
Loading