Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.1: Relax matches_id_short regex. #310

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

s-heppner
Copy link
Collaborator

Previously, the matches_id_short regular expression only allowed letters, digits and underscores.

With the decision of
aas-specs#295,
this condition was relaxed to allow also hyphens.

Fixes #304

Previously, the `matches_id_short` regular expression only allowed
letters, digits and underscores.

With the decision of
[aas-specs#295](admin-shell-io/aas-specs#295),
this condition was relaxed to allow also hyphens.

Fixes #304
@s-heppner s-heppner added the V3.1 SpecAAS V3.1 label Feb 15, 2024
@s-heppner s-heppner added this to the V3.1 milestone Feb 15, 2024
@zrgt zrgt self-requested a review February 18, 2024 21:45
Copy link
Collaborator

@zrgt zrgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-heppner s-heppner merged commit 22f8515 into V3.1/main Feb 19, 2024
2 checks passed
@s-heppner s-heppner deleted the V3.1/AASd-002Regex branch February 19, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3.1 SpecAAS V3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants