V3.1: Make Entity.entity_type optional #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `Entity.entity_type` was mandatory, however v3.1 changes this. We adapt the class defintion, as well as the invariant of AASd-014. Fix #306
s-heppner
commented
Feb 15, 2024
| ), | ||
| "Constraint AASd-014: Either the attribute global asset ID or " | ||
| "specific asset ID must be set if entity type is set to self-managed entity. " | ||
| "They are not existing otherwise." | ||
| "specific asset ID must be set if Entity/entityType is set to :attr:`Entity_type.Self_managed_entity`." | ||
| ) |
There was a problem hiding this comment.
Can someone please pay additional attention to my adaptation of the invariant? Does this do what it says it does?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Entity.entity_typewas mandatory, however v3.1 changes this.We adapt the class defintion, as well as the invariant of AASd-014.
Fix #306