[V3] Fix the pattern in xs:date for offset #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We incorrectly did not group the offset for `+14:00` or `-14:00`, so it could be directly concatenated to the year in `xs:date`'s. This patch fixes the issue, so the incorrect dates are correctly recognized.
mristin
force-pushed
the
mristin/Fix-xs-date-pattern
branch
from
d9e4d51
to
583a3b6
Compare
|
@s-heppner @zrgt please propagate this patch to V3.1 at your next convenience. |
mristin
added a commit
that referenced
this pull request
Mar 22, 2024
We propagate the fix in #320 from V3 to V3.1 where a time zone offset of `14:00` without a sign was mistakenly accepted by the regular expressions.
mristin
added a commit
that referenced
this pull request
Mar 22, 2024
We propagate the fix in #320 from V3 to V3.1 where a time zone offset of `14:00` without a sign was mistakenly accepted by the regular expressions.
mristin
added a commit
that referenced
this pull request
Mar 22, 2024
We propagate the fix in #320 from V3 to V3.1 where a time zone offset of `14:00` without a sign was mistakenly accepted by the regular expressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We incorrectly did not group the offset for
+14:00or-14:00, so it could be directly concatenated to the day inxs:date's.This patch fixes the issue, so the incorrect dates are correctly recognized.