Report unexpected test in XML sequences #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we break out of the loop when parsing sequences of
XML elements representing properties of an instances. This gives
misleading error messages ("required property not set").
Instead, with this patch, we report that the text is unexpected, which
is much clearer to the user.
mristin
deleted the
mristin/Fix-reporting-unexpected-text-in-XML-sequences
branch
mristin
added a commit
that referenced
this pull request
Jun 28, 2023
* Report unexpected test in XML sequences (#19) * Update to aas-core-meta, codegen, testgen 44756fb, e2b793f, bf3720d7 (#18) * This is an important patch propagating in particular the following fixes which affected the constraints and their documentation: * Pull requests in aas-core-meta [#271], [#272] and [#273] which affect the nullability checks in constraints, * Pull request in aas-core-meta [#275] which affects the documentation of many constraints.
Merged
mristin
added a commit
that referenced
this pull request
Jun 28, 2023
* Report unexpected text in XML sequences (#19) * Update to aas-core-meta, codegen, testgen 44756fb, e2b793f, bf3720d7 (#18) * This is an important patch propagating in particular the following fixes which affected the constraints and their documentation: * Pull requests in aas-core-meta 271, 272 and 273 which affect the nullability checks in constraints, * Pull request in aas-core-meta 275 which affects the documentation of many constraints.
mristin
added a commit
that referenced
this pull request
Jun 28, 2023
* Report unexpected text in XML sequences (#19) * Update to aas-core-meta, codegen, testgen 44756fb, e2b793f, bf3720d7 (#18) * This is an important patch propagating in particular the following fixes which affected the constraints and their documentation: * Pull requests in aas-core-meta 271, 272 and 273 which affect the nullability checks in constraints, * Pull request in aas-core-meta 275 which affects the documentation of many constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we break out of the loop when parsing sequences of XML elements representing properties of an instances. This gives misleading error messages ("required property not set").
Instead, with this patch, we report that the text is unexpected, which is much clearer to the user.