-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments not ignored when language is set to Kotlin #38
Comments
Analysis:
=> I assume that Note: All tests have been done with PMD version 6.13.0. |
It is strange because comments in 'java' code are ignored while comments in 'kotlin' code are not ignored. Using the PMD standalone tool 'kotlin' comments are ignored. Is it a bug while choosing the language incorrectly?
It is strange because comments in 'java' code are ignored while comments in 'kotlin' code are not ignored. Using the PMD standalone tool 'kotlin' comments are ignored. Is it a bug while choosing the language incorrectly?
Please also note @isuPatches that pmd-kotlin is available since 6.10.0 such that not in 6.8.0 which is used in https://github.com/isuPatches/WiseFy/pull/121/files#diff-a64dfe2d629b6972b45671eb3a81a735. Using the 6.8.0 standalone, no results at all are produced setting the language to |
It is strange because comments in 'java' code are ignored while comments in 'kotlin' code are not ignored. Using the PMD standalone tool 'kotlin' comments are ignored. Is it a bug while choosing the language incorrectly?
Thank you! |
Still having some issues with ANTLR runtime ... cannot reproduce it. The thrown exception has the following cause:
@isuPatches can you try using my snapshot version on your machine by adding the following to your
I am looking forward to your feedback... |
I did a test using the 1.4-SNAPSHOT. With tool version set to I see this:
Without the tool version set I see: 'Could not detect CPD language for 'kotlin', using any language as fallback.' |
Very strange, my explicitly added test cases failed before and worked after the change ... Just to be sure: using |
Update: @isuPatches, you can also check the newest 1.4-SNAPSHOT version. It is still WIP but works properly on my machine with your code :-) If you give me a go, I can create a new release ;-) |
Use some mechanisms as for report configuration
Use some mechanisms as for report configuration
Use some mechanisms as for report configuration
Hey! I took another look at this. I've tried:
It looks like comments are no longer being flagged as duplicate, so looks okay to me now! Thank you. |
@isuPatches Thanks for testing and coming back. May I ask you another favor to test version |
Sure! I tried to pull it locally but am getting:
|
Thanks for the reply. It seems that the first upload of version Could you try again? |
2.0-SNAPSHOT looks clear of the comment issue! The only thing I'm seeing that's unexpected is:
I'm not sure if the SNAPSHOT includes the fix for that issue. |
* use-worker-api: add JDKs 10 and 11 for travis-ci test minimal possible toolVersion and fallback language remove deprecated API adjust minimal required PMD version create executor configuration and move to dedicated package (#38) add check methods for state of task before actually execute anything use serializable report configuration for CpdAction (#38) remove no longer required excludes remove unnecessary loggers for report implementations Use Gradle's Worker API (#32) use 'getByName' consistent to other test cases remove @optional for non-optional properties add integration test which really executes CPD add both test sourceSets to gradlePlugin
Could use some help...when I change:
to:
Then comment blocks such as:
are labled as duplicate code.
The text was updated successfully, but these errors were encountered: