Implemented asClickableFileUrl #18
Conversation
|
Hi @prestontim, thanks for the PR. Is your issue urgent? Otherwise I will try to fix #16 as well within the next weeks. |
|
@aaschmid - It's kind of urgent, but a week or two won't kill us. We need to get Gradle 2.14 up-and-running as soon as possible because we're trying to get Buildship 1.0.16 working (which requires Gradle 2.14). https://discuss.gradle.org/t/buildship-1-0-16-is-now-available/18056 |
|
OK, @prestontim. Will try to fix the other issue on the weekend. Thanks for your patience |
| try { | ||
| return new URI("file", "", path.toURI().getPath(), null, null).toString(); | ||
| } catch (URISyntaxException e) { | ||
| throw UncheckedException.throwAsUncheckedException(e); |
There was a problem hiding this comment.
The import of UncheckedException is missing as far as I could see and as this is Groovy it will fail at runtime at earliest.
There was a problem hiding this comment.
You need to copy UncheckedException as well (fortunately it's the last link of the chain :D)
|
@aaschmid @bishiboosh Included copy of Gradle's UncheckedException. The oraclejdk8 build seems to be passing now, but the others are still failing. Not sure if that's something that I caused or if that's expected. Please let me know if there's anything else that I need to do. |
|
@prestontim Thanks for the update, I would rather prefer using Due to the travis.io jobs: I haven't had time to look at them but they are very fragile with no obvious case. If one is stable, the code at least is working :-) |
* Implmented asClickableFileUrl method since ConsoleRenderer has been removed (fixes #17). * Include copy of Gradle's internal UncheckedException class
* prestontim_master: Implemented asClickableFileUrl (#18)
|
prestontim the new version is now be available, see https://github.com/aaschmid/gradle-cpd-plugin/releases/tag/v1.0. Feedback welcome. |
|
Unfortunately, the plugin does not show up on https://plugins.gradle.org/search?term=cpd, yet. We have to be patient I guess ... |
|
@aaschmid The new version is working great! Thank you so much for your quick response. |
|
you are welcome :-) |
Implemented local asClickableFileUrl method, since ConsoleRenderer has been removed in Gradle 2.14 (fixes #17).