Fix the Video Links in Main Page

[todo]

For some reason, it gives poster link in current scenario and also order of links are not correct.

---

Insta-Downloader-Extension/download.js

Lines 226 to 231 in 79deeed

	* @todo Fix the Video Links in Main Page
	* @body For some reason, it gives poster link in current scenario and also order of links are not correct.
	*/
	if (videos[j] && videos[j].src) {
	dlink = videos[j].src
	}

---

This issue was generated by todo based on a @todo comment in 79deeed. It's been assigned to @aashutoshrathi because they committed the code.

[IssueHuntBot]

@issuehuntfest has funded $20.00 to this issue. See it on IssueHunt

[lalitmee]

Hey @aashutoshrathi, I looked into this and I have fixed one thing that why it was taking the poster image and not the video but it is working only if you are having 2 or 3 videos on the currently loaded page. After then it is somehow missing the order and it is downloading the images.

[aashutoshrathi]

Yes, I'm working on it.
If you found some fix, feel free to open PR.

[aashutoshrathi]

I nearly fixed this yesterday, but I don't know something is losing track of videos in array.

[lalitmee]

So I will create a PR with a little fix.

[lalitmee]

Actually, just now I took pull so your code is coming which I think you changed and I also changed at the same place.

Only this is sufficient

      if (videos[j] && videos[j].poster === dlink) {

if we are doing this while creating videos array

      videos[i].poster = `${videos[i].poster}&dl=1`
      videos[i].src = `${videos[i].currentSrc}&dl=1`

I think thats why our previous condition is failing and it is never going inside that if condition to get the video URL. Because we are changing dlink but we are not changing the poster link. That's why that condition is failing.

Correct me if missed something.

[aashutoshrathi]

@lalitmee I think you are right. 🎉
If you want open a PR, I would love to test it.
I just missed the fact that we are adding &dl=1

[lalitmee]

Yeah, and yesterday when I was playing around, I found that this &dl=1 is not stopping adding to any image URL. It means if any user will scroll a lot that many &dl=1 all the images will be having.

I think it should be added any URL only one time not again and again.

[aashutoshrathi]

I fixed it last night, but missed that poster will also have them 😅

[aashutoshrathi]

@lalitmee Are you on Telegram?

[aashutoshrathi]

Please submit your PR on issuehunt to get the funds released.

[lalitmee]

Hey @aashutoshrathi, actually I also wanted to connect with you. I am on telegram.

[aashutoshrathi]

Ping me here

[IssueHuntBot]

@lalitmee has submitted a pull request. See it on IssueHunt

[IssueHuntBot]

@aashutoshrathi has rewarded $14.00 to @lalitmee. See it on IssueHunt

• 💰 Total deposit: $20.00
• 🎉 Repository reward(20%): $4.00
• 🔧 Service fee(10%): $2.00