Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Commands for CMD and PS #74

Closed
wants to merge 1 commit into from
Closed

Fix Commands for CMD and PS #74

wants to merge 1 commit into from

Conversation

Sagar2366
Copy link

@Sagar2366 Sagar2366 commented Apr 5, 2019 •
edited by aashutoshrathi

Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you successfully ran tests with your changes locally?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

Issues Solved

Fixes #65

aashutoshrathi
aashutoshrathi requested changes Apr 5, 2019
View reviewed changes
Copy link
Owner

@aashutoshrathi aashutoshrathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thanks for the PR!
And you have got the crux of this issue, but this can be fixed with a better approach.
i.e. declare a string cmd ='logic' and if platform[0] == 'W' then pass else cmd = './'+cmd

I hope you got what I'm saying. This way you won't have to repeat the dict.

tc_generator/lang_compiler.py
LANGS = [{'req': 'gcc',
import sys
platform = sys.platform
if(platform.lower()== 'windows'):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need of brackets around if condition and please give spaces around ==

tc_generator/lang_compiler.py
'link': 'https://golang.org/doc/install',
'compile': 'go build logic.go'},
]
elif(platform.lower()== 'linux'):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it else, instead.

tc_generator/lang_compiler.py
@@ -22,4 +51,4 @@
'command': './logic',
'link': 'https://golang.org/doc/install',
'compile': 'go build logic.go'},
]
]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline at the end and follow PEP8 guidelines

@aashutoshrathi aashutoshrathi changed the title Fixing issue number 65 Fix Commands for CMD and PS Apr 7, 2019
@aashutoshrathi
Copy link
Owner

@Sagar2366 Update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashutoshrathi aashutoshrathi aashutoshrathi requested changes

Assignees
No one assigned
Labels
status/inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add commands for CMD and Powershell
2 participants
@Sagar2366 @aashutoshrathi