let whiny_persistence: true be the default now #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alto
changed the title
alto
added a commit
that referenced
this pull request
Aug 24, 2016
|
I'm confused, the changelog says for v3.0.0:
Which seems to not be the case, since this PR is open? |
|
@andyw8 |
|
@alto any reason why 5.0 was released without this? Also, I'm curious why the bump to 5.x if it seems like there weren't breaking changes... |
|
@swrobel We bumped to 5.x because of internal architecture change in AASM |
|
Is there a way to set it by default on app load/init stage with the current version? |
tamaloa
added a commit
to tamaloa/aasm
that referenced
this pull request
Jan 13, 2022
As many before we have been bitten by the default behaviour of bang events to NOT raise exceptions. It took me quite a while to figure out why this does not work as expected as first search results only returned eferences which state that raising an exception has been "fixed" (for instance aasm#262). Only after quite a while I found out, that raising exceptions on bang events by default will only be part of aasm version 6 (aasm#378). I hope the small documentation change will help others.
|
👍🏻 should be by default |
|
@anilmaurya is there any reason this shouldn't be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #366, this PR sets the default
whiny_persistencesetting to true (DSL/behavior change). So, by default,transition!will fail if the object is invalid.true