Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for namespaces #472

Merged
merged 1 commit into from Aug 8, 2017

Conversation

allspiritseve
Copy link
Contributor

No description provided.

@anilmaurya
Copy link
Member

Thank you @allspiritseve for contributing .

Recently AASM added namespace for events method #476 which makes this PR little outdated, Can you update docs ?

@allspiritseve
Copy link
Contributor Author

@anilmaurya not sure what all was outdated, but I updated the example to change review_status events: approve_review => approve and unapprove_review => unapprove since events now get aliased automatically.

Let me know if you'd like any other changes.

@anilmaurya anilmaurya merged commit 217131c into aasm:master Aug 8, 2017
@anilmaurya
Copy link
Member

@allspiritseve Thank you ♡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants